Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: sdk/lib/_internal/pub/lib/src/io.dart

Issue 141113011: Support directories other than "web" in pub build. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Revise. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/io.dart
diff --git a/sdk/lib/_internal/pub/lib/src/io.dart b/sdk/lib/_internal/pub/lib/src/io.dart
index 804267c5ec52486310735452d036f1f42f31ac23..3f17a0236af0a641838a5522d65567346ee913c7 100644
--- a/sdk/lib/_internal/pub/lib/src/io.dart
+++ b/sdk/lib/_internal/pub/lib/src/io.dart
@@ -14,6 +14,7 @@ import 'package:path/path.dart' as path;
import 'package:http/http.dart' show ByteStream;
import 'package:stack_trace/stack_trace.dart';
+import 'exit_codes.dart' as exit_codes;
import 'error_group.dart';
import 'log.dart' as log;
import 'pool.dart';
@@ -727,7 +728,7 @@ Future<bool> extractTarGz(Stream<List<int>> stream, String destination) {
]);
}).then((results) {
var exitCode = results[1];
- if (exitCode != 0) {
+ if (exitCode != exit_codes.SUCCESS) {
throw new Exception("Failed to extract .tar.gz stream to $destination "
"(exit code $exitCode).");
}
@@ -759,7 +760,7 @@ Future<bool> _extractTarGzWindows(Stream<List<int>> stream,
// path because 7zip says "A full path is not allowed here."
return runProcess(pathTo7zip, ['e', 'data.tar.gz'], workingDir: tempDir);
}).then((result) {
- if (result.exitCode != 0) {
+ if (result.exitCode != exit_codes.SUCCESS) {
throw new Exception('Could not un-gzip (exit code ${result.exitCode}). '
'Error:\n'
'${result.stdout.join("\n")}\n'
@@ -776,7 +777,7 @@ Future<bool> _extractTarGzWindows(Stream<List<int>> stream,
// Untar the archive into the destination directory.
return runProcess(pathTo7zip, ['x', tarFile], workingDir: destination);
}).then((result) {
- if (result.exitCode != 0) {
+ if (result.exitCode != exit_codes.SUCCESS) {
throw new Exception('Could not un-tar (exit code ${result.exitCode}). '
'Error:\n'
'${result.stdout.join("\n")}\n'
@@ -855,7 +856,7 @@ class PubProcessResult {
const PubProcessResult(this.stdout, this.stderr, this.exitCode);
- bool get success => exitCode == 0;
+ bool get success => exitCode == exit_codes.SUCCESS;
}
/// Gets a [Uri] for [uri], which can either already be one, or be a [String].

Powered by Google App Engine
This is Rietveld 408576698