Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: sdk/lib/_internal/pub/test/build/includes_assets_from_dependencies_test.dart

Issue 141113011: Support directories other than "web" in pub build. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/test/build/includes_assets_from_dependencies_test.dart
diff --git a/sdk/lib/_internal/pub/test/build/includes_assets_from_dependencies_test.dart b/sdk/lib/_internal/pub/test/build/includes_assets_from_dependencies_test.dart
index 1455808d965975d28c96c4d59c22360b4af67a77..c53551b77734699db41b47cdef18e59edef4becb 100644
--- a/sdk/lib/_internal/pub/test/build/includes_assets_from_dependencies_test.dart
+++ b/sdk/lib/_internal/pub/test/build/includes_assets_from_dependencies_test.dart
@@ -29,24 +29,40 @@ main() {
d.appPubspec({
"foo": {"path": "../foo"}
}),
+ d.dir("example", [
+ d.file("index.html", "html"),
+ ]),
nweiz 2014/01/28 03:21:51 I don't like testing "example" here as well. This
Bob Nystrom 2014/01/28 23:02:04 In order to test that they are included, they have
nweiz 2014/01/29 01:24:35 I'd rather just test (any) one directory and consi
Bob Nystrom 2014/01/29 19:03:38 We don't tend to go minimal in our integration tes
d.dir("web", [
d.file("index.html", "html"),
])
]).create();
- schedulePub(args: ["build"],
- output: new RegExp(r"Built 3 files!"),
+ schedulePub(args: ["build", "*"],
+ output: new RegExp(r"Built 6 files!"),
exitCode: 0);
d.dir(appPath, [
d.dir('build', [
- d.file("index.html", "html"),
- d.dir('assets', [
- d.dir('foo', [
- d.file('foo.txt', 'foo'),
- d.dir('sub', [
- d.file('bar.txt', 'bar'),
- ]),
+ d.dir('example', [
+ d.file("index.html", "html"),
+ d.dir('assets', [
+ d.dir('foo', [
+ d.file('foo.txt', 'foo'),
+ d.dir('sub', [
+ d.file('bar.txt', 'bar'),
+ ]),
+ ])
+ ])
+ ]),
+ d.dir('web', [
+ d.file("index.html", "html"),
+ d.dir('assets', [
+ d.dir('foo', [
+ d.file('foo.txt', 'foo'),
+ d.dir('sub', [
+ d.file('bar.txt', 'bar'),
+ ]),
+ ])
])
])
])

Powered by Google App Engine
This is Rietveld 408576698