Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1411123014: [Line Layout API] Convert SVGTextLayoutEngine and SVGTextLayoutEngineBaseline to line Layout API (Closed)

Created:
5 years, 1 month ago by pilgrim_google
Modified:
5 years, 1 month ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Line Layout API] Convert SVGTextLayoutEngine and SVGTextLayoutEngineBaseline to line Layout API This CL converts references to LayoutSVGInlineText* objects and some general LayoutObject* to the equivalent objects in the new line layout API (LineLayoutSVGInlineText and LineLayoutItem). No functional changes. BUG=499321 Committed: https://crrev.com/4a49a2181721b40522602efeda671aa6d1a2a832 Cr-Commit-Position: refs/heads/master@{#357170}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
pilgrim_google
5 years, 1 month ago (2015-10-30 14:35:12 UTC) #2
eae
LGTM
5 years, 1 month ago (2015-10-30 18:20:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411123014/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411123014/1
5 years, 1 month ago (2015-10-30 18:21:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 19:24:05 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 19:25:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a49a2181721b40522602efeda671aa6d1a2a832
Cr-Commit-Position: refs/heads/master@{#357170}

Powered by Google App Engine
This is Rietveld 408576698