Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1456)

Unified Diff: lib/src/percent/decoder.dart

Issue 1411123012: Use the new Uint8Buffer.addAll start and end params. (Closed) Base URL: git@github.com:dart-lang/convert.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « CHANGELOG.md ('k') | pubspec.yaml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/percent/decoder.dart
diff --git a/lib/src/percent/decoder.dart b/lib/src/percent/decoder.dart
index 07406361680363ff1a7f197f2831883dc1bc73cf..4d8f9941b2c540e8c0f8b923df10a0bef7c9c1ef 100644
--- a/lib/src/percent/decoder.dart
+++ b/lib/src/percent/decoder.dart
@@ -199,7 +199,7 @@ int _decode(List<int> codeUnits, int start, int end, Uint8Buffer buffer) {
// than can be copied to the buffer as-is.
if (i > sliceStart) {
_checkForInvalidCodeUnit(codeUnitOr, codeUnits, sliceStart, i);
- buffer.addAll(codeUnits.getRange(sliceStart, i));
+ buffer.addAll(codeUnits, sliceStart, i);
}
// Now decode the percent-encoded byte and add it as well.
@@ -222,7 +222,7 @@ int _decode(List<int> codeUnits, int start, int end, Uint8Buffer buffer) {
if (start == sliceStart) {
buffer.addAll(codeUnits);
} else {
- buffer.addAll(codeUnits.getRange(sliceStart, end));
+ buffer.addAll(codeUnits, sliceStart, end);
}
}
« no previous file with comments | « CHANGELOG.md ('k') | pubspec.yaml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698