Issue 1411103011: Call setUseMobileViewportStyle before setViewportEnabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411103011: Call setUseMobileViewportStyle before setViewportEnabled (Closed)

Created:
5 years, 1 month ago by Yoav Weiss

Modified:
5 years, 1 month ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2526

Target Ref:
refs/pending/branch-heads/2526

Project:
chromium

Visibility:
Public.

More Reviews

Description

Call setUseMobileViewportStyle before setViewportEnabled In order to avoid initialization of the preloadScanner with the wrong viewport dimensions, this CL moves the initialization of mobile viewport dimensions further up, so that they would happen before the viewport is initialized. BUG=531820 Review URL: https://codereview.chromium.org/1392213002 Cr-Commit-Position: refs/heads/master@{#355041} (cherry picked from commit a1a508b42224a697a0a621c36bfb55fe2f8bd760) Committed: https://chromium.googlesource.com/chromium/src/+/5774a5164e0f9b35aa3a98b6375dc897881b2a44

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -7 lines)			Patch
A	content/browser/resource_loading_browsertest.cc	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	content/content_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
A +	content/test/data/resource_loading/200.png	View	Binary file		0 comments	Download
A +	content/test/data/resource_loading/400.png	View	Binary file		0 comments	Download
A	content/test/data/resource_loading/resource_loading_non_mobile.html	View	1 chunk	+30 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/web/DevToolsEmulator.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Yoav Weiss

5 years, 1 month ago (2015-11-04 10:13:22 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5774a5164e0f9b35aa3a98b6375dc897881b2a44.

Expand Messages | Collapse Messages