Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1411103006: Make AstRawString deduplication encoding-agnostic. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make AstRawString deduplication encoding-agnostic. R=jkummerow@chromium.org BUG=v8:4450 LOG=N Committed: https://crrev.com/200315cb26e3320661d80daa4788e321d9910de5 Cr-Commit-Position: refs/heads/master@{#31624}

Patch Set 1 #

Patch Set 2 : add test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -7 lines) Patch
M src/ast-value-factory.cc View 2 chunks +26 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-4450.js View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Yang
5 years, 1 month ago (2015-10-28 10:28:50 UTC) #1
Jakob Kummerow
lgtm
5 years, 1 month ago (2015-10-28 10:35:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411103006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411103006/1
5 years, 1 month ago (2015-10-28 10:41:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411103006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411103006/20001
5 years, 1 month ago (2015-10-28 10:52:44 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-28 11:28:33 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 11:29:03 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/200315cb26e3320661d80daa4788e321d9910de5
Cr-Commit-Position: refs/heads/master@{#31624}

Powered by Google App Engine
This is Rietveld 408576698