Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1411103003: Update SrcRectConstraint doc (Closed)

Created:
5 years, 2 months ago by bsalomon
Modified:
5 years, 2 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update SrcRectConstraint doc. Previous doc never matched the implementation or the c2d spec. Committed: https://skia.googlesource.com/skia/+/19e82e3b9f6fb5a02fc033121f2047b4d886112e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/core/SkCanvas.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
1 pixel is only true for bilerp and not for bicubic or mip. Personally, I ...
5 years, 2 months ago (2015-10-23 16:08:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411103003/1
5 years, 2 months ago (2015-10-23 16:10:08 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-10-23 16:10:08 UTC) #5
reed1
lgtm
5 years, 2 months ago (2015-10-23 16:26:26 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-23 16:27:45 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/19e82e3b9f6fb5a02fc033121f2047b4d886112e

Powered by Google App Engine
This is Rietveld 408576698