Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1312)

Unified Diff: src/scopes.h

Issue 1411093008: Properly handle direct evals referencing super in arrow functions (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/es6/regress/regress-4522.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/scopes.h
diff --git a/src/scopes.h b/src/scopes.h
index 6c976d90bd666f533381dd419a2cba97abcac110..25c090c9a503085bd47eb51ba042b5abe33ccfcf 100644
--- a/src/scopes.h
+++ b/src/scopes.h
@@ -357,9 +357,10 @@ class Scope: public ZoneObject {
bool NeedsHomeObject() const {
return scope_uses_super_property_ ||
- (scope_calls_eval_ && (IsConciseMethod(function_kind()) ||
- IsAccessorFunction(function_kind()) ||
- IsClassConstructor(function_kind())));
+ ((scope_calls_eval_ || inner_scope_calls_eval_) &&
+ (IsConciseMethod(function_kind()) ||
+ IsAccessorFunction(function_kind()) ||
+ IsClassConstructor(function_kind())));
}
const Scope* NearestOuterEvalScope() const {
« no previous file with comments | « no previous file | test/mjsunit/es6/regress/regress-4522.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698