Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1411093008: Properly handle direct evals referencing super in arrow functions (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Properly handle direct evals referencing super in arrow functions The fix is to broaden the set of cases for when NeedsHomeObject() returns true. Note that this is broader than it needs to be (since, e.g., non-arrow function scopes inside a method can't reference super). But we don't track the types of inner scopes at the moment, so this is the best we can do. R=rossberg@chromium.org BUG=v8:4522 LOG=n Committed: https://crrev.com/4c3c89c1dea9c43a4a818705a55a31cd39a2dab3 Cr-Commit-Position: refs/heads/master@{#31659}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M src/scopes.h View 1 chunk +4 lines, -3 lines 0 comments Download
A + test/mjsunit/es6/regress/regress-4522.js View 1 chunk +12 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
adamk
5 years, 1 month ago (2015-10-28 21:18:54 UTC) #1
rossberg
lgtm
5 years, 1 month ago (2015-10-29 10:42:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411093008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411093008/1
5 years, 1 month ago (2015-10-29 15:08:02 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-29 15:09:32 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 15:10:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c3c89c1dea9c43a4a818705a55a31cd39a2dab3
Cr-Commit-Position: refs/heads/master@{#31659}

Powered by Google App Engine
This is Rietveld 408576698