Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1411093006: [turbofan] Factor out platform-independent part of InstructionSelector::VisitCall. (Closed)

Created:
5 years, 1 month ago by Jarin
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Factor out platform-independent part of InstructionSelector::VisitCall. Committed: https://crrev.com/a3f782f2609864e033bb02373cfebdff351e4ad2 Cr-Commit-Position: refs/heads/master@{#31547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -436 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 3 chunks +6 lines, -56 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +7 lines, -59 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 4 chunks +6 lines, -53 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +61 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 3 chunks +6 lines, -53 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 3 chunks +6 lines, -54 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 4 chunks +5 lines, -55 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 4 chunks +6 lines, -53 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 4 chunks +6 lines, -53 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jarin
Could you take a look, please?
5 years, 1 month ago (2015-10-26 07:00:26 UTC) #2
Benedikt Meurer
LGTM. It would be nice to unify that somehow with TailCalls
5 years, 1 month ago (2015-10-26 07:54:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411093006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411093006/1
5 years, 1 month ago (2015-10-26 07:55:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-26 07:56:08 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 07:56:37 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a3f782f2609864e033bb02373cfebdff351e4ad2
Cr-Commit-Position: refs/heads/master@{#31547}

Powered by Google App Engine
This is Rietveld 408576698