Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1411093002: PrivateScriptRunner::installClassIfNeeded should not run for a null frame (Closed)

Created:
5 years, 2 months ago by haraken
Modified:
5 years, 2 months ago
Reviewers:
tasak
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PrivateScriptRunner::installClassIfNeeded should not run for a null frame BUG=543538 Committed: https://crrev.com/2868c654caf3f77d932301f3ca52ff0edae03064 Cr-Commit-Position: refs/heads/master@{#354763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/html/marquee-without-frame-no-crash.html View 1 chunk +11 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/html/marquee-without-frame-no-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
haraken
PTAL
5 years, 2 months ago (2015-10-18 23:51:54 UTC) #2
tasak
lgtm
5 years, 2 months ago (2015-10-19 05:00:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411093002/1
5 years, 2 months ago (2015-10-19 07:14:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/122274)
5 years, 2 months ago (2015-10-19 09:50:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411093002/1
5 years, 2 months ago (2015-10-19 10:22:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 12:09:49 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 12:10:49 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/2868c654caf3f77d932301f3ca52ff0edae03064
Cr-Commit-Position: refs/heads/master@{#354763}

Powered by Google App Engine
This is Rietveld 408576698