Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: runtime/vm/message.cc

Issue 1411083007: Make sure that Dart_Ports are printed safely in the service protocol (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/message.cc
diff --git a/runtime/vm/message.cc b/runtime/vm/message.cc
index dc638b2602cdf8d902671a584a31e6b3baca99d0..54f40b4eeb77c91cee4a35bbd2c5d356a0e75b48 100644
--- a/runtime/vm/message.cc
+++ b/runtime/vm/message.cc
@@ -196,8 +196,8 @@ void MessageQueue::PrintJSON(JSONStream* stream) {
current->Id());
message.AddProperty("size", current->len());
message.AddProperty("index", depth++);
- message.AddProperty("_destinationPort",
- static_cast<intptr_t>(current->dest_port()));
+ message.AddPropertyF("_destinationPort", "%" Pd64 "",
+ static_cast<int64_t>(current->dest_port()));
message.AddProperty("_priority",
Message::PriorityAsString(current->priority()));
// TODO(johnmccutchan): Move port -> handler map out of Dart and into the
« no previous file with comments | « runtime/vm/isolate.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698