Issue 1411083007: Make sure that Dart_Ports are printed safely in the service protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1411083007: Make sure that Dart_Ports are printed safely in the service protocol (Closed)

Created:
5 years, 2 months ago by Cutch

Modified:
5 years, 2 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make sure that Dart_Ports are printed safely in the service protocol - A Dart_Port is a random 64-bit integer. - On 32-bit architectures we were silently truncating the isolate id when printing. - Parsing in JavaScript would also have issues. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/9c4d06a4f260511c90d7be3ba7a3035d425d855f

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	runtime/vm/isolate.cc	View		1 chunk	+6 lines, -6 lines	0 comments	Download
	M	runtime/vm/message.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (2 generated)

Cutch

5 years, 2 months ago (2015-10-20 16:47:40 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9c4d06a4f260511c90d7be3ba7a3035d425d855f (presubmit successful).