Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 1411083004: Fix tests of DartObject.hasKnownValue. (Closed)

Created:
5 years, 2 months ago by Paul Berry
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix tests of DartObject.hasKnownValue. The tests were exercising the semantics of the old (deprecated) method hasExactValue, and thus they were failing. TBR=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/2d3fe73b363b3757db494a3458bd08c0f63f5f80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M pkg/analyzer/test/generated/all_the_rest_test.dart View 6 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Berry
Committed patchset #1 (id:1) manually as 2d3fe73b363b3757db494a3458bd08c0f63f5f80 (presubmit successful).
5 years, 2 months ago (2015-10-19 14:32:58 UTC) #1
Brian Wilkerson
5 years, 2 months ago (2015-10-19 14:45:02 UTC) #2
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698