content/test/data/cross_site_iframe_factory.html - Issue 1411073005: Migrating tests to use EmbeddedTestServer (/content)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/test/data/cross_site_iframe_factory.html

Issue 1411073005: Migrating tests to use EmbeddedTestServer (/content) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/test/data/cross_site_iframe_factory.html

diff --git a/content/test/data/cross_site_iframe_factory.html b/content/test/data/cross_site_iframe_factory.html

index 5084f4c6fd20d012e121925820c8a3f1231e3ca4..e4e808b041461eda169f7f0d7944ba1233d43be1 100644

--- a/content/test/data/cross_site_iframe_factory.html

+++ b/content/test/data/cross_site_iframe_factory.html

@@ -21,7 +21,7 @@ To make this page work, your browsertest needs a MockHostResolver, like:

void SetUpOnMainThread() override {

host_resolver()->AddRule("*", "127.0.0.1");

- ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

+ ASSERT_TRUE(embedded_test_server()->Start());

}

You can play around with the arguments by loading this page via file://, but

« no previous file with comments | « content/test/data/cross_site_document_request_target.html ('k') | content/test/ppapi/ppapi_test.h » ('j') | no next file with comments »