content/browser/renderer_host/render_process_host_browsertest.cc - Issue 1411073005: Migrating tests to use EmbeddedTestServer (/content)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_process_host_browsertest.cc

Issue 1411073005: Migrating tests to use EmbeddedTestServer (/content) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_message_filter_browsertest.cc ('k') | content/browser/renderer_host/render_view_host_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_process_host_browsertest.cc

diff --git a/content/browser/renderer_host/render_process_host_browsertest.cc b/content/browser/renderer_host/render_process_host_browsertest.cc

index 1d5ed5532b58d801194335dbc6cc4e893bf6f2fd..96a58033342b44bfc66dba5a8b388175c26607b3 100644

--- a/content/browser/renderer_host/render_process_host_browsertest.cc

+++ b/content/browser/renderer_host/render_process_host_browsertest.cc

@@ -62,7 +62,7 @@ class RenderProcessHostTest : public ContentBrowserTest,

// http://crbug.com/87176.

IN_PROC_BROWSER_TEST_F(RenderProcessHostTest,

ShutdownRequestFromActiveTabIgnored) {

- ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

+ ASSERT_TRUE(embedded_test_server()->Start());

GURL test_url = embedded_test_server()->GetURL("/simple_page.html");

NavigateToURL(shell(), test_url);

@@ -90,7 +90,7 @@ IN_PROC_BROWSER_TEST_F(RenderProcessHostTest,

// Set max renderers to 1 to force running out of processes.

content::RenderProcessHost::SetMaxRendererProcessCount(1);

- ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

+ ASSERT_TRUE(embedded_test_server()->Start());

GURL test_url = embedded_test_server()->GetURL("/simple_page.html");

NavigateToURL(shell(), test_url);

@@ -160,7 +160,7 @@ class ObserverLogger : public RenderProcessHostObserver {

IN_PROC_BROWSER_TEST_F(RenderProcessHostTest,

AllProcessExitedCallsBeforeAnyHostDestroyedCalls) {

- ASSERT_TRUE(embedded_test_server()->InitializeAndWaitUntilReady());

+ ASSERT_TRUE(embedded_test_server()->Start());

GURL test_url = embedded_test_server()->GetURL("/simple_page.html");

NavigateToURL(shell(), test_url);