content/browser/loader/async_resource_handler_browsertest.cc - Issue 1411073005: Migrating tests to use EmbeddedTestServer (/content)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/async_resource_handler_browsertest.cc

Issue 1411073005: Migrating tests to use EmbeddedTestServer (/content) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_browsertest.cc ('k') | content/browser/loader/cross_site_resource_handler_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/async_resource_handler_browsertest.cc

diff --git a/content/browser/loader/async_resource_handler_browsertest.cc b/content/browser/loader/async_resource_handler_browsertest.cc

index 4276ce2b0aeffd6b93c18d8dacc6a339b4e459ae..08d253e987da97ea34241b063152140b8969e09b 100644

--- a/content/browser/loader/async_resource_handler_browsertest.cc

+++ b/content/browser/loader/async_resource_handler_browsertest.cc

@@ -65,8 +65,8 @@ class AsyncResourceHandlerBrowserTest : public ContentBrowserTest {

};

IN_PROC_BROWSER_TEST_F(AsyncResourceHandlerBrowserTest, UploadProgress) {

- net::test_server::EmbeddedTestServer* test_server = embedded_test_server();

- ASSERT_TRUE(test_server->InitializeAndWaitUntilReady());

+ net::EmbeddedTestServer* test_server = embedded_test_server();

+ ASSERT_TRUE(test_server->Start());

test_server->RegisterRequestHandler(

base::Bind(&HandlePostAndRedirectURLs, kPostPath));

@@ -85,8 +85,8 @@ IN_PROC_BROWSER_TEST_F(AsyncResourceHandlerBrowserTest, UploadProgress) {

IN_PROC_BROWSER_TEST_F(AsyncResourceHandlerBrowserTest,

UploadProgressRedirect) {

- net::test_server::EmbeddedTestServer* test_server = embedded_test_server();

- ASSERT_TRUE(test_server->InitializeAndWaitUntilReady());

+ net::EmbeddedTestServer* test_server = embedded_test_server();

+ ASSERT_TRUE(test_server->Start());

test_server->RegisterRequestHandler(

base::Bind(&HandlePostAndRedirectURLs, kRedirectPostPath));