content/browser/devtools/site_per_process_devtools_browsertest.cc - Issue 1411073005: Migrating tests to use EmbeddedTestServer (/content)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/site_per_process_devtools_browsertest.cc

Issue 1411073005: Migrating tests to use EmbeddedTestServer (/content) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/devtools_protocol_browsertest.cc ('k') | content/browser/download/download_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/site_per_process_devtools_browsertest.cc

diff --git a/content/browser/devtools/site_per_process_devtools_browsertest.cc b/content/browser/devtools/site_per_process_devtools_browsertest.cc

index 80f15238db875184ce564fc4d9fc80708370d3f2..661ab8f26334d8e16970a38d8294abce1fd8ef22 100644

--- a/content/browser/devtools/site_per_process_devtools_browsertest.cc

+++ b/content/browser/devtools/site_per_process_devtools_browsertest.cc

@@ -53,8 +53,7 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest,

MAYBE_CrossSiteIframeAgentHost) {

DevToolsAgentHost::List list;

host_resolver()->AddRule("*", "127.0.0.1");

- ASSERT_TRUE(test_server()->Start());

- GURL main_url(test_server()->GetURL("files/site_per_process_main.html"));

+ GURL main_url(embedded_test_server()->GetURL("/site_per_process_main.html"));

NavigateToURL(shell(), main_url);

// It is safe to obtain the root frame tree node here, as it doesn't change.

@@ -69,7 +68,7 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest,

// Load same-site page into iframe.

FrameTreeNode* child = root->child_at(0);

- GURL http_url(test_server()->GetURL("files/title1.html"));

+ GURL http_url(embedded_test_server()->GetURL("/title1.html"));

NavigateFrameToURL(child, http_url);

list = DevToolsAgentHost::GetOrCreateAll();

@@ -79,7 +78,7 @@ IN_PROC_BROWSER_TEST_F(SitePerProcessDevToolsBrowserTest,

// Load cross-site page into iframe.

GURL::Replacements replace_host;

- GURL cross_site_url(test_server()->GetURL("files/title2.html"));

+ GURL cross_site_url(embedded_test_server()->GetURL("/title2.html"));

replace_host.SetHostStr("foo.com");

cross_site_url = cross_site_url.ReplaceComponents(replace_host);

NavigateFrameToURL(root->child_at(0), cross_site_url);