Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Unified Diff: content/renderer/resource_fetcher_browsertest.cc

Issue 1411073005: Migrating tests to use EmbeddedTestServer (/content) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/resource_fetcher_browsertest.cc
diff --git a/content/renderer/resource_fetcher_browsertest.cc b/content/renderer/resource_fetcher_browsertest.cc
index 0d76e2deb6c93f7206fb56621ae5a02a7958fa4a..3f2dac6f2772a6f837e5e31da2c42fa3687c77be 100644
--- a/content/renderer/resource_fetcher_browsertest.cc
+++ b/content/renderer/resource_fetcher_browsertest.cc
@@ -180,7 +180,6 @@ class ResourceFetcherTests : public ContentBrowserTest {
ASSERT_TRUE(delegate->completed());
EXPECT_EQ(delegate->response().httpStatusCode(), 404);
- EXPECT_TRUE(delegate->data().find("Not Found.") != std::string::npos);
}
void ResourceFetcherDidFailOnRenderer() {
@@ -295,8 +294,8 @@ IN_PROC_BROWSER_TEST_F(ResourceFetcherTests, ResourceFetcherDownload) {
// Need to spin up the renderer.
NavigateToURL(shell(), GURL(url::kAboutBlankURL));
- ASSERT_TRUE(test_server()->Start());
- GURL url(test_server()->GetURL("files/simple_page.html"));
+ ASSERT_TRUE(embedded_test_server()->Start());
+ GURL url(embedded_test_server()->GetURL("/simple_page.html"));
PostTaskToInProcessRendererAndWait(
base::Bind(&ResourceFetcherTests::ResourceFetcherDownloadOnRenderer,
@@ -308,8 +307,8 @@ IN_PROC_BROWSER_TEST_F(ResourceFetcherTests, ResourceFetcher404) {
NavigateToURL(shell(), GURL(url::kAboutBlankURL));
// Test 404 response.
- ASSERT_TRUE(test_server()->Start());
- GURL url = test_server()->GetURL("files/thisfiledoesntexist.html");
+ ASSERT_TRUE(embedded_test_server()->Start());
+ GURL url = embedded_test_server()->GetURL("/thisfiledoesntexist.html");
PostTaskToInProcessRendererAndWait(
base::Bind(&ResourceFetcherTests::ResourceFetcher404OnRenderer,
@@ -332,8 +331,8 @@ IN_PROC_BROWSER_TEST_F(ResourceFetcherTests, ResourceFetcherTimeout) {
// Grab a page that takes at least 1 sec to respond, but set the fetcher to
// timeout in 0 sec.
- ASSERT_TRUE(test_server()->Start());
- GURL url(test_server()->GetURL("slow?1"));
+ ASSERT_TRUE(embedded_test_server()->Start());
+ GURL url(embedded_test_server()->GetURL("/slow?1"));
PostTaskToInProcessRendererAndWait(
base::Bind(&ResourceFetcherTests::ResourceFetcherTimeoutOnRenderer,
@@ -346,8 +345,8 @@ IN_PROC_BROWSER_TEST_F(ResourceFetcherTests, ResourceFetcherDeletedInCallback) {
// Grab a page that takes at least 1 sec to respond, but set the fetcher to
// timeout in 0 sec.
- ASSERT_TRUE(test_server()->Start());
- GURL url(test_server()->GetURL("slow?1"));
+ ASSERT_TRUE(embedded_test_server()->Start());
+ GURL url(embedded_test_server()->GetURL("/slow?1"));
PostTaskToInProcessRendererAndWait(
base::Bind(
@@ -363,8 +362,8 @@ IN_PROC_BROWSER_TEST_F(ResourceFetcherTests, ResourceFetcherPost) {
NavigateToURL(shell(), GURL(url::kAboutBlankURL));
// Grab a page that echos the POST body.
- ASSERT_TRUE(test_server()->Start());
- GURL url(test_server()->GetURL("echo"));
+ ASSERT_TRUE(embedded_test_server()->Start());
+ GURL url(embedded_test_server()->GetURL("/echo"));
PostTaskToInProcessRendererAndWait(
base::Bind(
@@ -378,8 +377,8 @@ IN_PROC_BROWSER_TEST_F(ResourceFetcherTests, ResourceFetcherSetHeader) {
NavigateToURL(shell(), GURL(url::kAboutBlankURL));
// Grab a page that echos the POST body.
- ASSERT_TRUE(test_server()->Start());
- GURL url(test_server()->GetURL("echoheader?header"));
+ ASSERT_TRUE(embedded_test_server()->Start());
+ GURL url(embedded_test_server()->GetURL("/echoheader?header"));
PostTaskToInProcessRendererAndWait(
base::Bind(

Powered by Google App Engine
This is Rietveld 408576698