mojo/common/BUILD.gn - Issue 1411063007: Add mojo::StrongBindingSet and use it in GeolocationServiceContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/common/BUILD.gn

Issue 1411063007: Add mojo::StrongBindingSet and use it in GeolocationServiceContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/geolocation/geolocation_service_impl.h ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | mojo/common/service_set.h » ('j') | mojo/common/service_set.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/common/BUILD.gn

diff --git a/mojo/common/BUILD.gn b/mojo/common/BUILD.gn

index 0d8f3554c06c93427b30add4c32f5f882db1e83b..c0b935dfe97c062696617a3728561d91c9bc9188 100644

--- a/mojo/common/BUILD.gn

+++ b/mojo/common/BUILD.gn

@@ -23,6 +23,7 @@ component("common_base") {

"data_pipe_file_utils.cc",

"data_pipe_utils.cc",

"data_pipe_utils.h",

+ "service_set.h",

"user_agent.cc",

"user_agent.h",

"weak_binding_set.h",

@@ -84,6 +85,7 @@ test("mojo_common_unittests") {

"//third_party/mojo/src/mojo/edk/test:test_support",

"//third_party/mojo/src/mojo/public/cpp/bindings",

"//third_party/mojo/src/mojo/public/cpp/test_support:test_utils",

+ "//third_party/mojo/src/mojo/public/interfaces/bindings/tests:test_interfaces",

"//url",

]

@@ -93,5 +95,6 @@ test("mojo_common_unittests") {

"../message_pump/handle_watcher_unittest.cc",

"../message_pump/message_pump_mojo_unittest.cc",

"common_type_converters_unittest.cc",

+ "service_set_unittest.cc",

]

}

« content/browser/geolocation/geolocation_service_impl.h ('K') | « content/browser/web_contents/web_contents_impl.cc ('k') | mojo/common/service_set.h » ('j') | mojo/common/service_set.h » ('J')