Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1411063006: Update the mDNS native extension for Mac OS to handle PTR and SRV records (Closed)

Created:
5 years, 1 month ago by Søren Gjesse
Modified:
5 years, 1 month ago
Reviewers:
wibling, karlklose
CC:
fletch+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/fletch.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update the mDNS native extension for Mac OS to handle PTR and SRV records Change to use the API DNSServiceQueryRecord to support all record types. R=wibling@google.com, karlklose@google.com BUG= Committed: https://github.com/dart-lang/fletch/commit/97735dea475554e5aca901b3b44ce88da7f863de

Patch Set 1 #

Patch Set 2 : Fixed long line #

Total comments: 2

Patch Set 3 : Addressed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -117 lines) Patch
M pkg/mdns/bin/mdns-sd.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/mdns/lib/native/libmdns_extension_lib.dylib.sha1 View 1 chunk +1 line, -1 line 0 comments Download
M pkg/mdns/lib/src/constants.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/mdns/lib/src/native_extension_client.dart View 2 chunks +41 lines, -17 lines 0 comments Download
M pkg/mdns/lib/src/packet.dart View 1 2 3 chunks +61 lines, -44 lines 0 comments Download
M pkg/mdns/test/decode_test.dart View 3 chunks +41 lines, -0 lines 0 comments Download
M src/pkg/mdns/mdns_extension.h View 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/mdns/mdns_extension.cc View 1 chunk +26 lines, -17 lines 0 comments Download
M src/pkg/mdns/mdns_extension_macos.cc View 1 1 chunk +52 lines, -36 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Søren Gjesse
5 years, 1 month ago (2015-11-09 14:57:52 UTC) #1
wibling
lgtm https://codereview.chromium.org/1411063006/diff/20001/pkg/mdns/lib/src/packet.dart File pkg/mdns/lib/src/packet.dart (right): https://codereview.chromium.org/1411063006/diff/20001/pkg/mdns/lib/src/packet.dart#newcode136 pkg/mdns/lib/src/packet.dart:136: if (partLength != 0) { NIT: > 0
5 years, 1 month ago (2015-11-10 15:02:00 UTC) #3
Søren Gjesse
Committed patchset #3 (id:40001) manually as 97735dea475554e5aca901b3b44ce88da7f863de.
5 years, 1 month ago (2015-11-10 15:12:22 UTC) #4
Søren Gjesse
5 years, 1 month ago (2015-11-10 15:30:42 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1411063006/diff/20001/pkg/mdns/lib/src/packet...
File pkg/mdns/lib/src/packet.dart (right):

https://codereview.chromium.org/1411063006/diff/20001/pkg/mdns/lib/src/packet...
pkg/mdns/lib/src/packet.dart:136: if (partLength != 0) {
On 2015/11/10 15:02:00, wibling wrote:
> NIT: > 0

Done.

Powered by Google App Engine
This is Rietveld 408576698