Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1411043008: Fix the build after commit 8cadf995e9a0. (Closed)

Created:
5 years, 1 month ago by Lei Zhang
Modified:
5 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix the build after commit 8cadf995e9a0. Do not store raw wide string pointers. BUG=551248 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/955930dce7e4b5c764cdd34b134baea4207de523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M fpdfsdk/src/fpdfformfill_embeddertest.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M testing/embedder_test_timer_handling_delegate.h View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lei Zhang
5 years, 1 month ago (2015-11-04 23:02:43 UTC) #2
Tom Sepez
lgtm
5 years, 1 month ago (2015-11-04 23:04:00 UTC) #3
Lei Zhang
5 years, 1 month ago (2015-11-04 23:04:56 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
955930dce7e4b5c764cdd34b134baea4207de523 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698