Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 # Copyright 2015 Google Inc. | |
| 2 # | |
| 3 # Use of this source code is governed by a BSD-style license that can be | |
| 4 # found in the LICENSE file. | |
| 5 | |
| 6 { | |
| 7 'targets': [ | |
| 8 { | |
| 9 'target_name': 'sdl', | |
| 10 'product_name': 'sdl', | |
| 11 'type': 'shared_library', | |
| 12 'include_dirs': [ | |
| 13 '<(base_dir)/<(skia_os)', | |
| 14 '<(src_dir)/include', | |
| 15 ], | |
| 16 'includes': [ | |
| 17 'sdl_sources.gypi', | |
| 18 ], | |
| 19 'sources': [ | |
| 20 '<@(sdl_sources)', | |
|
mtklein
2015/10/28 21:12:15
Is this the same deal? Why can't we just write ou
joshualitt
2015/10/29 13:51:39
see below.
| |
| 21 ], | |
| 22 'direct_dependent_settings': { | |
| 23 'include_dirs': [ | |
| 24 '<(src_dir)/include', | |
| 25 ] | |
| 26 }, | |
| 27 'cflags': [ | |
| 28 '-g', | |
| 29 '-Wall' | |
|
mtklein
2015/10/28 21:12:15
Do we really care about warnings in SDL? I'd sugg
joshualitt
2015/10/29 13:51:39
Acknowledged.
| |
| 30 ], | |
| 31 'conditions': [ | |
| 32 ['skia_os == "linux"', { | |
| 33 'includes': [ | |
| 34 'linux/sdl_linux.gypi', | |
|
mtklein
2015/10/28 21:12:15
Is this just a factoring preference, or is somethi
joshualitt
2015/10/29 13:51:39
I prefer smaller gyps which show the core logic, a
| |
| 35 ] | |
| 36 }], | |
| 37 ], | |
| 38 }, | |
| 39 ], | |
| 40 } | |
| OLD | NEW |