Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1411033002: Add basic line drawing command (Closed)

Created:
5 years, 2 months ago by cpu_(ooo_6.6-7.5)
Modified:
5 years, 2 months ago
Reviewers:
travisg, scottmg
Base URL:
https://github.com/travisg/lk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add basic line drawing command and clean up tabs in the file. BUG= R=travisg@google.com Committed: db1ff1983d7af9b6aea5876e2ec6eb517bbff0ac

Patch Set 1 #

Total comments: 4

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+470 lines, -416 lines) Patch
M include/lib/gfx.h View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/gfx/gfx.c View 1 12 chunks +467 lines, -416 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cpu_(ooo_6.6-7.5)
Not sure why some functions look all green, outside the draw_line I only changed tabs ...
5 years, 2 months ago (2015-10-17 01:15:55 UTC) #2
travisg
lgtm except for the formatting nits. https://codereview.chromium.org/1411033002/diff/1/lib/gfx/gfx.c File lib/gfx/gfx.c (right): https://codereview.chromium.org/1411033002/diff/1/lib/gfx/gfx.c#newcode274 lib/gfx/gfx.c:274: if (dxabs >= ...
5 years, 2 months ago (2015-10-17 01:21:47 UTC) #3
cpu_(ooo_6.6-7.5)
done, pushing in a minute once I try different targets.
5 years, 2 months ago (2015-10-17 01:30:37 UTC) #4
scottmg
https://codereview.chromium.org/1411033002/diff/1/lib/gfx/gfx.c File lib/gfx/gfx.c (right): https://codereview.chromium.org/1411033002/diff/1/lib/gfx/gfx.c#newcode268 lib/gfx/gfx.c:268: uint x = dyabs >> 1; these lines could ...
5 years, 2 months ago (2015-10-17 01:31:21 UTC) #6
cpu_(ooo_6.6-7.5)
5 years, 2 months ago (2015-10-17 01:45:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
db1ff1983d7af9b6aea5876e2ec6eb517bbff0ac (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698