Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 141103007: Fixing valgrind problem with wallpaper animation (Closed)

Created:
6 years, 10 months ago by Mr4D (OOO till 08-26)
Modified:
6 years, 10 months ago
Reviewers:
Dmitry Polukhin, bshe
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Fixing valgrind problem with wallpaper animation BUG=- TEST=fixing unit test R=bshe@chromium.org, dpolukhin@chromium.org TBR=dpolukhin@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247719

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M chrome/browser/chromeos/login/wallpaper_manager.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mr4D (OOO till 08-26)
Please have a look!
6 years, 10 months ago (2014-01-29 16:59:58 UTC) #1
bshe
On 2014/01/29 16:59:58, Mr4D wrote: > Please have a look! lgtm
6 years, 10 months ago (2014-01-29 17:03:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/141103007/1
6 years, 10 months ago (2014-01-29 17:08:36 UTC) #3
Dmitry Polukhin
lgtm
6 years, 10 months ago (2014-01-29 17:40:16 UTC) #4
Mr4D (OOO till 08-26)
Committed patchset #1 manually as r247719 (presubmit successful).
6 years, 10 months ago (2014-01-29 18:11:33 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-01-29 18:14:03 UTC) #6
Message was sent while issue was closed. 
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698