LayoutTests/editing/inserting/insert-with-mutation-event.html - Issue 141103006: Protect document.execCommand() from recursive call and DOM mutation events

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/inserting/insert-with-mutation-event.html

Issue 141103006: Protect document.execCommand() from recursive call and DOM mutation events (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: 2014-01-29T17:06:03 Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <body>

	3 <div id="sample" contenteditable="true">

	4 foo

	5 <div id="test" style="font-weight:bold">bar</div>

	6 </div>

	7 </body>

	8 <script>

	9 if (window.testRunner)

	10 testRunner.dumpAsText();

	11 function $(id) { return document.getElementById(id); }

	12 window.getSelection().collapse($('test'), 0);

	13 document.execCommand('Delete');

	14 var sample = $('sample');

	15 sample.addEventListener('DOMSubtreeModified', function () {

	16 // Move nodes being processed by 'InsertText' to another document.

	17 var anotherDoc = document.implementation.createDocument('', null);

	18 anotherDoc.adoptNode(sample);

	19 });

	20 document.execCommand('InsertText', false, 'ab123cd');

	21 document.body.textContent = 'PASS; NOT CRASHED';

	22 </script>
	tkent 2014/01/29 08:22:01 I don't understand how recursive execCommand happe I don't understand how recursive execCommand happens in this test. Would you explain it please? yosin_UTC9 2014/01/29 09:13:30 This test is checks mutation event handler not to Show quoted text On 2014/01/29 08:22:01, tkent wrote: > I don't understand how recursive execCommand happens in this test. Would you > explain it please? This test is checks mutation event handler not to be executed during execCommand(). A test for recursive call is in https://codereview.chromium.org/71163005, which originally introduced recursive call checking.
OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/inserting/insert-with-mutation-event-expected.txt » ('j') | no next file with comments »