Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1411013004: Image filters: simplify filterInputGPU(). (Closed)

Created:
5 years, 1 month ago by Stephen White
Modified:
5 years, 1 month ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Image filters: simplify filterInputGPU(). Remove a call to canFilterImageGPU() / filterImageGPU() from filterInputGPU(). There's no reason to do this, since the subsequent filterImage() call will do it for us anyway. And this call actually defeats caching (as demonstrated by the attached bench). BUG=skia: Committed: https://skia.googlesource.com/skia/+/7b87ee7a1c43ad9d4d20955cc25f3c31af161bb5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -15 lines) Patch
M bench/ImageFilterDAGBench.cpp View 2 chunks +32 lines, -0 lines 0 comments Download
M src/core/SkImageFilter.cpp View 1 chunk +11 lines, -15 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Stephen White
Brian: PTAL. Thanks!
5 years, 1 month ago (2015-10-26 13:38:01 UTC) #2
bsalomon
lgtm
5 years, 1 month ago (2015-10-26 13:43:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1411013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1411013004/1
5 years, 1 month ago (2015-10-26 13:44:55 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-10-26 13:55:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7b87ee7a1c43ad9d4d20955cc25f3c31af161bb5

Powered by Google App Engine
This is Rietveld 408576698