Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1411013003: Analysis Options error notifications. (Closed)

Created:
5 years, 2 months ago by pquitslund
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -9 lines) Patch
M pkg/analysis_server/lib/src/status/get_handler.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_analysis_options_test.dart View 2 chunks +15 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/source/analysis_options_provider.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/plugin/engine_plugin.dart View 2 chunks +3 lines, -0 lines 0 comments Download
M pkg/analyzer/test/source/analysis_options_provider_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
pquitslund
5 years, 2 months ago (2015-10-21 16:50:12 UTC) #2
scheglov
LGTM
5 years, 2 months ago (2015-10-21 16:53:30 UTC) #3
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-21 16:56:12 UTC) #4
pquitslund
5 years, 2 months ago (2015-10-21 16:59:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c85fe785a85b1a907ce05f440dd08b2fd0fd994 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698