Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Issue 1410993009: Move interpreter cctests into v8::internal::interpreter namespace. (Closed)

Created:
5 years, 1 month ago by Michael Starzinger
Modified:
5 years, 1 month ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Move interpreter cctests into v8::internal::interpreter namespace. This moves the cctest file for the interpreter to live in the same namespace as the components it is testing. Hence we can avoid the forbidden using directives pulling in entire namespaces. From the Google C++ style guide: "You may not use a using-directive to make all names from a namespace available". This would be covered by presubmit linter checks if build/namespaces were not blacklisted. R=rmcilroy@chromium.org Committed: https://crrev.com/d1805edada73aafb751ebc1a3d6d12262b53acb7 Cr-Commit-Position: refs/heads/master@{#31681}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M test/cctest/interpreter/test-interpreter.cc View 2 chunks +4 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 1 month ago (2015-10-30 10:11:17 UTC) #1
rmcilroy
LGTM, thanks! (I did this originally because it seemed like cctest wouldn't run the tests ...
5 years, 1 month ago (2015-10-30 10:41:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410993009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410993009/1
5 years, 1 month ago (2015-10-30 10:47:27 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 11:05:22 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 11:05:58 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1805edada73aafb751ebc1a3d6d12262b53acb7
Cr-Commit-Position: refs/heads/master@{#31681}

Powered by Google App Engine
This is Rietveld 408576698