Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1410993008: Remove RegExp.multiline accessors. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove RegExp.multiline accessors. This is non-standard and not even documented on MDN. On Firefox, setting RegExp.multiline to true adds the multiline flag to all newly created RegExp objects (both from constructor and from literal). In V8 this has no effect. Source archaelogy shows that this is from the initial commit. R=bmeurer@chromium.org Committed: https://crrev.com/e8f752ce0c2a488e88cd87fe75f3907b4303d0a0 Cr-Commit-Position: refs/heads/master@{#31673}

Patch Set 1 #

Patch Set 2 : change test #

Patch Set 3 : git cl set_commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -21 lines) Patch
M src/js/regexp.js View 1 chunk +0 lines, -19 lines 0 comments Download
M test/mjsunit/regexp-static.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M test/mozilla/mozilla.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Yang
5 years, 1 month ago (2015-10-30 08:24:15 UTC) #1
Benedikt Meurer
lgtm
5 years, 1 month ago (2015-10-30 08:25:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410993008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410993008/1
5 years, 1 month ago (2015-10-30 08:26:11 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/5950) v8_mac_rel on tryserver.v8 (JOB_FAILED, ...
5 years, 1 month ago (2015-10-30 08:36:28 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410993008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410993008/20001
5 years, 1 month ago (2015-10-30 08:41:41 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/11195)
5 years, 1 month ago (2015-10-30 08:53:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410993008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410993008/40001
5 years, 1 month ago (2015-10-30 09:27:09 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-10-30 09:46:09 UTC) #14
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e8f752ce0c2a488e88cd87fe75f3907b4303d0a0 Cr-Commit-Position: refs/heads/master@{#31673}
5 years, 1 month ago (2015-10-30 09:46:35 UTC) #15
Michael Achenbach
5 years, 1 month ago (2015-10-30 10:46:41 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1431433004/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Causes layout test failures..

Powered by Google App Engine
This is Rietveld 408576698