Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1410993005: Support dictionary prefs in chrome.settingsPrivate (Closed)

Created:
5 years, 2 months ago by michaelpg
Modified:
5 years, 2 months ago
Reviewers:
Finnur, stevenjb
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support dictionary prefs in chrome.settingsPrivate BUG=425627 R=stevenjb@chromium.org,finnur@chromium.org Committed: https://crrev.com/707d9719f47ddf265e42f49d9d73f17dff40e444 Cr-Commit-Position: refs/heads/master@{#355269}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -1 line) Patch
M chrome/browser/extensions/api/settings_private/prefs_util.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/settings_private.idl View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/settings/prefs_test_cases.js View 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
michaelpg
5 years, 2 months ago (2015-10-21 03:31:58 UTC) #3
Finnur
LGTM (review and extensions/ owners approval).
5 years, 2 months ago (2015-10-21 10:52:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410993005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410993005/1
5 years, 2 months ago (2015-10-21 11:20:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-21 11:24:21 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 11:25:10 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/707d9719f47ddf265e42f49d9d73f17dff40e444
Cr-Commit-Position: refs/heads/master@{#355269}

Powered by Google App Engine
This is Rietveld 408576698