Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1410983003: Index Dart CompilationUnit(s) with the correct context. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Index Dart CompilationUnit(s) with the correct context. We should use the context that they belong to, not the context that we got them through. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f80bd4203de33faecad89983ec8d3fd35ceba4a4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 2 months ago (2015-10-19 16:56:18 UTC) #1
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-19 16:57:30 UTC) #2
scheglov
5 years, 2 months ago (2015-10-19 17:00:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f80bd4203de33faecad89983ec8d3fd35ceba4a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698