Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1410963003: [turbofan] Temporary workaround for JSInliner zone. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_inlining-heuristic-4
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Temporary workaround for JSInliner zone. This is exactly what it looks like. A temporary hack that ensures we can make forward progress with the JSInliner despite other components have a hard time picking the correct zone. This hack is a hack! R=bmeurer@chromium.org,jarin@chromium.org Committed: https://crrev.com/68a74034f2644e898f75e3bd0cf77c5b7ee712c3 Cr-Commit-Position: refs/heads/master@{#31380}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/compiler/js-inlining.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Starzinger
5 years, 2 months ago (2015-10-19 14:36:47 UTC) #1
Jarin
lgtm
5 years, 2 months ago (2015-10-19 14:37:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410963003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410963003/20001
5 years, 2 months ago (2015-10-19 15:07:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-19 15:09:10 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/68a74034f2644e898f75e3bd0cf77c5b7ee712c3 Cr-Commit-Position: refs/heads/master@{#31380}
5 years, 2 months ago (2015-10-19 15:09:28 UTC) #8
Benedikt Meurer
5 years, 2 months ago (2015-10-19 17:26:10 UTC) #9
Message was sent while issue was closed.
LGTM, thanks.

Powered by Google App Engine
This is Rietveld 408576698