[Interpreter] Adds delete operator to interpreter.

test/cctest/interpreter/test-bytecode-generator.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/compiler.h"
 #include "src/interpreter/bytecode-array-iterator.h"
 #include "src/interpreter/bytecode-generator.h"
 #include "src/interpreter/interpreter.h"
@@ skipping 1816 matching lines @@
        1,
        8,
        {
            B(LdaSmi8), U8(13),  //
            B(Star), R(0),       // TODO(oth): Ldar R(X) following Star R(X)
            B(Ldar), R(0),       // could be culled in bytecode array builder.
            B(TypeOf),           //
            B(Return),           //
        },
        0},
-  };
+      {"var x = 13;"
+       "return ~x;",
+       1 * kPointerSize,
+       1,
+       9,
+       {
+           B(LdaSmi8), U8(13),   //
+           B(Star), R(0),        //
+           B(LdaSmi8), U8(-1),   //
+           B(BitwiseXor), R(0),  //
+           B(Return),            //
+       },
+       0},
+      {"var x = 13;"
+       "return +x;",
+       1 * kPointerSize,
+       1,
+       9,
+       {
+           B(LdaSmi8), U8(13),  //
+           B(Star), R(0),       //
+           B(LdaSmi8), U8(1),   //
+           B(Mul), R(0),        //
+           B(Return),           //
+       },
+       0},
+      {"var x = 13;"
+       "return -x;",
+       1 * kPointerSize,
+       1,
+       9,
+       {
+           B(LdaSmi8), U8(13),  //
+           B(Star), R(0),       //
+           B(LdaSmi8), U8(-1),  //
+           B(Mul), R(0),        //
+           B(Return),           //
+       },
+       0}};
 
   for (size_t i = 0; i < arraysize(snippets); i++) {
     Handle<BytecodeArray> bytecode_array =
+        helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
+    CheckBytecodeArrayEqual(snippets[i], bytecode_array);
+  }
+}
+
+
+TEST(Delete) {

[rmcilroy, 2015/10/26 14:31:07]

Could you also make have a TEST(GlobalDelete) with a test or two for deleting
global objects (i.e., similar to GlobalCountOperators) 

[mythria, 2015/10/27 10:50:48]

Done.

+  InitializedHandleScope handle_scope;
+  BytecodeGeneratorHelper helper;
+
+  int deep_elements_flags =
+      ObjectLiteral::kFastElements | ObjectLiteral::kDisableMementos;
+  int closure = Register::function_closure().index();
+  int first_context_slot = Context::MIN_CONTEXT_SLOTS;
+
+  ExpectedSnippet<InstanceType> snippets[] = {
+      {"var a = {x:13, y:14}; return delete a.x;",
+       1 * kPointerSize,
+       1,
+       12,
+       {
+           B(LdaConstant), U8(0),                                   //
+           B(CreateObjectLiteral), U8(0), U8(deep_elements_flags),  //
+           B(Star), R(0),                                           //
+           B(LdaConstant), U8(1),                                   //
+           B(DeletePropertySloppy), R(0),                           //
+           B(Return)
+       },
+       2,
+       {InstanceType::FIXED_ARRAY_TYPE,
+        InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
+      {"'use strict'; var a = {x:13, y:14}; return delete a.x;",
+       1 * kPointerSize,
+       1,
+       12,
+       {
+           B(LdaConstant), U8(0),                                   //
+           B(CreateObjectLiteral), U8(0), U8(deep_elements_flags),  //
+           B(Star), R(0),                                           //
+           B(LdaConstant), U8(1),                                   //
+           B(DeletePropertyStrict), R(0),                           //
+           B(Return)
+       },
+       2,
+       {InstanceType::FIXED_ARRAY_TYPE,
+        InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
+      {"var a = {1:13, 2:14}; return delete a[2];",
+       1 * kPointerSize,
+       1,
+       12,
+       {
+           B(LdaConstant), U8(0),                                   //
+           B(CreateObjectLiteral), U8(0), U8(deep_elements_flags),  //
+           B(Star), R(0),                                           //
+           B(LdaSmi8), U8(2),                                       //
+           B(DeletePropertySloppy), R(0),                           //
+           B(Return)
+       },
+       1,
+       {InstanceType::FIXED_ARRAY_TYPE}
+      },
+      {"var a = 10; return delete a;",
+       1 * kPointerSize,
+       1,
+       6,
+       {
+           B(LdaSmi8), U8(10),                                      //
+           B(Star), R(0),                                           //
+           B(LdaFalse),                                             //
+           B(Return)
+       },
+       0
+      },
+      {"'use strict';"
+       "var a = {1:10};"
+       "(function f1() {return a;});"
+       "return delete a[1];",
+       2 * kPointerSize,
+       1,
+       29,
+       {
+           B(CallRuntime), U16(Runtime::kNewFunctionContext),       //
+                                R(closure), U8(1),                  //
+           B(PushContext), R(0),                                    //
+           B(LdaConstant), U8(0),                                   //
+           B(CreateObjectLiteral), U8(0), U8(deep_elements_flags),  //
+           B(StaContextSlot), R(0), U8(first_context_slot),         //
+           B(LdaConstant), U8(1),                                   //
+           B(CreateClosure), U8(0),                                 //
+           B(LdaContextSlot), R(0), U8(first_context_slot),         //
+           B(Star), R(1),                                           //
+           B(LdaSmi8), U8(1),                                       //
+           B(DeletePropertyStrict), R(1),                           //
+           B(Return)
+       },
+       2,
+       {InstanceType::FIXED_ARRAY_TYPE,
+        InstanceType::SHARED_FUNCTION_INFO_TYPE}},
+    };

[rmcilroy, 2015/10/26 14:31:07]

nit - could you also test your unresolvable reference code path (i.e., "delete
'test';" 

[mythria, 2015/10/27 10:50:48]

Done.

+
+  for (size_t i = 0; i < arraysize(snippets); i++) {
+    Handle<BytecodeArray> bytecode_array =
         helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
     CheckBytecodeArrayEqual(snippets[i], bytecode_array);
   }
 }
 
 
 TEST(FunctionLiterals) {
   InitializedHandleScope handle_scope;
   BytecodeGeneratorHelper helper;
 
@@ skipping 1638 matching lines @@
   for (size_t i = 0; i < arraysize(snippets); i++) {
     Handle<BytecodeArray> bytecode_array =
         helper.MakeBytecodeForFunctionBody(snippets[i].code_snippet);
     CheckBytecodeArrayEqual(snippets[i], bytecode_array);
   }
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8