Implements AddStartupEventsForTelemetry() in startup_metric_utils.cc for in-coming startup telemetry

base/trace_event/common/trace_event_common.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This header file defines the set of trace_event macros without specifying
 // how the events actually get collected and stored. If you need to expose trace
 // events to some other universe, you can copy-and-paste this file as well as
 // trace_event.h, modifying the macros contained there as necessary for the
 // target platform. The end result is that multiple libraries can funnel events
 // through to a shared trace event collector.
@@ skipping 291 matching lines @@
 #define TRACE_EVENT_COPY_INSTANT1(category_group, name, scope, arg1_name,   \
                                   arg1_val)                                 \
   INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_INSTANT, category_group, name, \
                            TRACE_EVENT_FLAG_COPY | scope, arg1_name, arg1_val)
 #define TRACE_EVENT_COPY_INSTANT2(category_group, name, scope, arg1_name,      \
                                   arg1_val, arg2_name, arg2_val)               \
   INTERNAL_TRACE_EVENT_ADD(TRACE_EVENT_PHASE_INSTANT, category_group, name,    \
                            TRACE_EVENT_FLAG_COPY | scope, arg1_name, arg1_val, \
                            arg2_name, arg2_val)
 
+#define TRACE_EVENT_INSTANT_WITH_TIMESTAMP(category_group, name, scope, \

[shatch, 2015/11/13 17:32:04]

Should this be TRACE_EVENT_MARK_WITH_TIMESTAMP0 and grouped with the _TIMESTAMP1
below?

[gabadie, 2015/11/16 12:09:03]

Actually not really. I asked charliea@chromium.org (who is in charge of
implementing the mark & measure standardized JS API) about this, and there is a
difference between an INSTANT event and a MARK event. A mark EVENT is pretty
much an INSTANT event. However the MARK event get also referenced on C++ side so
the JS API mark & measure can access it. If I was using MARK events, then these
startup specific events would be accessible on the w3c standardized API
(http://www.w3.org/TR/user-timing/), and we don't what that.

[shatch, 2015/11/16 14:58:30]

So should you be using TRACE_EVENT_PHASE_INSTANT instead, since you don't want
to use a MARK event but your macro specifies TRACE_EVENT_PHASE_MARK?

[gabadie, 2015/11/16 15:36:18]

Oups... Turned out one commit was missing in my branch. Good catch! My bad.

Fixed. =)

+                                           timestamp)                   \
+  INTERNAL_TRACE_EVENT_ADD_WITH_ID_TID_AND_TIMESTAMP(                   \
+      TRACE_EVENT_PHASE_MARK, category_group, name, 0, 0, timestamp,    \
+      TRACE_EVENT_FLAG_NONE)
+
 // Syntactic sugars for the sampling tracing in the main thread.
 #define TRACE_EVENT_SCOPED_SAMPLING_STATE(category, name) \
   TRACE_EVENT_SCOPED_SAMPLING_STATE_FOR_BUCKET(0, category, name)
 #define TRACE_EVENT_GET_SAMPLING_STATE() \
   TRACE_EVENT_GET_SAMPLING_STATE_FOR_BUCKET(0)
 #define TRACE_EVENT_SET_SAMPLING_STATE(category, name) \
   TRACE_EVENT_SET_SAMPLING_STATE_FOR_BUCKET(0, category, name)
 #define TRACE_EVENT_SET_NONCONST_SAMPLING_STATE(categoryAndName) \
   TRACE_EVENT_SET_NONCONST_SAMPLING_STATE_FOR_BUCKET(0, categoryAndName)
 
@@ skipping 717 matching lines @@
 
 // Enum reflecting the scope of an INSTANT event. Must fit within
 // TRACE_EVENT_FLAG_SCOPE_MASK.
 #define TRACE_EVENT_SCOPE_GLOBAL (static_cast<unsigned char>(0 << 3))
 #define TRACE_EVENT_SCOPE_PROCESS (static_cast<unsigned char>(1 << 3))
 #define TRACE_EVENT_SCOPE_THREAD (static_cast<unsigned char>(2 << 3))
 
 #define TRACE_EVENT_SCOPE_NAME_GLOBAL ('g')
 #define TRACE_EVENT_SCOPE_NAME_PROCESS ('p')
 #define TRACE_EVENT_SCOPE_NAME_THREAD ('t')