Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1410923006: Fix status file given new js_typed_interop test that cannot pass in dart2js checked mode without ri… (Closed)

Created:
5 years, 1 month ago by Jacob
Modified:
5 years, 1 month ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix status file given new js_typed_interop test that cannot pass in dart2js checked mode without risky changes. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/e0f8e96dae2c82005dc13499b674d43c059b7a29

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tests/html/html.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jacob
5 years, 1 month ago (2015-11-04 04:06:53 UTC) #2
sra1
lgtm
5 years, 1 month ago (2015-11-04 04:07:54 UTC) #3
Jacob
5 years, 1 month ago (2015-11-04 04:08:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e0f8e96dae2c82005dc13499b674d43c059b7a29 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698