HexStringToUInt64 should fail for negative input

base/strings/string_number_conversions.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/strings/string_number_conversions.h"
 
 #include <ctype.h>
 #include <errno.h>
 #include <stdlib.h>
 #include <wctype.h>
@@ skipping 482 matching lines @@
   return IteratorRangeToNumber<HexIteratorRangeToIntTraits>::Invoke(
     input.begin(), input.end(), output);
 }
 
 bool HexStringToInt64(const StringPiece& input, int64* output) {
   return IteratorRangeToNumber<HexIteratorRangeToInt64Traits>::Invoke(
     input.begin(), input.end(), output);
 }
 
 bool HexStringToUInt64(const StringPiece& input, uint64* output) {
+  if (input[0] == '-') {
+    return false;

[brettw, 2013/04/24 05:42:05]

The header file defines that the best effort result should saturate (so should
return 0 in the negative cases). Is there something broken in the template code?
It seems like there's a bunch of stuff to test for negative numbers, but I don't
see any unit tests for StringToUint so am suspicious.

[Mostyn Bramley-Moore, 2013/04/24 08:19:20]

The template code only seems to check for valid negative numbers (eg I think it
would spot "-12-12" as invalid), but does not check that the value type is
signed.

I moved the negativity/signed check inside the template code, I guess it's a
more complete fix (in case other unsigned types are added later).

+  }
   return IteratorRangeToNumber<HexIteratorRangeToUInt64Traits>::Invoke(
       input.begin(), input.end(), output);
 }
 
 bool HexStringToBytes(const std::string& input, std::vector<uint8>* output) {
   return HexStringToBytesT(input, output);
 }
 
 }  // namespace base