Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issue 14109014: Lets try this again. (Closed)

Created:
7 years, 8 months ago by michaeln
Modified:
7 years, 8 months ago
Reviewers:
tfarina, michaeln1, brettw, jam
CC:
chromium-reviews
Visibility:
Public.

Description

Lets try this again. Revert 193983 "Revert 193968 "Roll the DEPS for google-url."" > Revert 193968 "Roll the DEPS for google-url." > > > Roll the DEPS for google-url. > > > > And update all the references from build/temp_gyp/googleurl.gyp to url/url.gyp. > > > > This also changes googleurl.gyp to reference the files under url/, so that we > > don't break the Blink tree. > > > > BUG=229660 > > R=brettw@chromium.org > > TBR=brettw@chromium.org > > > > Review URL: https://chromiumcodereview.appspot.com/14089011 > > TBR=tfarina@chromium.org > Review URL: https://codereview.chromium.org/14028012 TBR=michaeln@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193992

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -181 lines) Patch
M trunk/src/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/ash.gyp View 4 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/build/all.gyp View 9 chunks +10 lines, -10 lines 0 comments Download
M trunk/src/build/temp_gyp/googleurl.gyp View 2 chunks +4 lines, -92 lines 0 comments Download
M trunk/src/chrome/chrome_browser.gypi View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_browser_chromeos.gypi View 2 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/chrome_browser_extensions.gypi View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_browser_ui.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/chrome_browser_ui_views.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_common.gypi View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/chrome/chrome_tests.gypi View 5 chunks +10 lines, -10 lines 0 comments Download
M trunk/src/chrome_frame/chrome_frame.gyp View 6 chunks +10 lines, -10 lines 0 comments Download
M trunk/src/cloud_print/service/service.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/components/autofill.gypi View 3 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/components/visitedlink.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/content_common.gypi View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/content/content_shell.gypi View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/content/content_tests.gypi View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/jingle/jingle.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/media/media.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/net/net.gyp View 10 chunks +10 lines, -10 lines 0 comments Download
M trunk/src/net/tools/tld_cleanup/tld_cleanup.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ppapi/ppapi_internal.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/printing/printing.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/rlz/rlz.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/sync/sync_core.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/sync/sync_internal_api.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/message_center/message_center.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/oak/oak.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/ui.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/ui_unittests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/views/controls/webview/webview.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/views/views.gyp View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/url/url.gyp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/webkit/base/webkit_base.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/webkit/glue/webkit_glue.gypi View 2 chunks +1 line, -1 line 0 comments Download
M trunk/src/webkit/storage/webkit_storage.gypi View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/webkit/tools/test_shell/test_shell.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/win8/metro_driver/metro_driver.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
michaeln
7 years, 8 months ago (2013-04-12 19:48:41 UTC) #1
michaeln
I'll try reverting the GURL roll revert here...
7 years, 8 months ago (2013-04-12 19:54:16 UTC) #2
michaeln
Committed patchset #1 manually as r193992 (presubmit successful).
7 years, 8 months ago (2013-04-12 20:13:22 UTC) #3
michaeln
trybots apparently don't know how to 'patch' drover generated diffs
7 years, 8 months ago (2013-04-12 20:15:09 UTC) #4
tfarina
7 years, 8 months ago (2013-04-12 20:52:15 UTC) #5
Message was sent while issue was closed.
Thanks for relanding it! ;)

Powered by Google App Engine
This is Rietveld 408576698