ARM: Enable VFP default NaN mode

ARM: Enable VFP default NaN mode

BUG=none
TEST=Default NaN tests added to test-assembler-arm.

Committed: https://code.google.com/p/v8/source/detail?r=14268

[ulan, 2013-04-15 07:43:01]

Looks good overall, a few questions:

https://codereview.chromium.org/14109010/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):

https://codereview.chromium.org/14109010/diff/1/src/arm/lithium-codegen-arm.c...
src/arm/lithium-codegen-arm.cc:4866: __ vadd(input_reg, input_reg,
kDoubleRegZero, ne);
In other places vsub is used to canonicalize. Maybe it is worth adding a masm
function for this, like CanonicalizeNaN(reg, cond).

https://codereview.chromium.org/14109010/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

https://codereview.chromium.org/14109010/diff/1/src/arm/macro-assembler-arm.c...
src/arm/macro-assembler-arm.cc:2032: vstr(d0, FieldMemOperand(scratch1,
Indentation is off.

https://codereview.chromium.org/14109010/diff/1/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):

https://codereview.chromium.org/14109010/diff/1/src/arm/stub-cache-arm.cc#new...
src/arm/stub-cache-arm.cc:1624: r4, r0, elements, r5, r2, r3, r9,
Why do we need this shuffling of scratch registers here and in other places?

https://codereview.chromium.org/14109010/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):

https://codereview.chromium.org/14109010/diff/1/src/hydrogen-instructions.cc#...
src/hydrogen-instructions.cc:3057: #ifdef V8_TARGET_ARCH_ARM
We try to avoid adding arch dependent ifdefs in hydrogen. Can we push this down
to lithium?

[ulan, 2013-04-15 15:00:56]

LGTM

https://codereview.chromium.org/14109010/diff/8001/src/arm/simulator-arm.cc
File src/arm/simulator-arm.cc (right):

https://codereview.chromium.org/14109010/diff/8001/src/arm/simulator-arm.cc#n...
src/arm/simulator-arm.cc:1874:
FixedDoubleArray::canonical_not_the_hole_nan_as_double(): value;
Add space before ":".

[m.m.capewell, 2013-04-15 15:56:04]

Committed patchset #2 manually as r14268 (presubmit successful).