Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3455)

Unified Diff: build/common.gypi

Issue 14109004: Do not instrument globals when running ASan on Mac. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 193923)
+++ build/common.gypi (working copy)
@@ -2978,6 +2978,13 @@
],
}],
],
+ 'conditions': [
+ ['OS=="mac"', {
+ 'cflags': [
+ '-mllvm -asan-globals=0', # http://crbug.com/196561
Nico 2013/04/22 22:20:29 Sorry, I missed this: 'cflags' isn't used on mac.
Alexander Potapenko 2013/04/23 10:09:04 See below, I'm also setting -asan-globals=0 in xco
+ ],
+ }],
+ ],
}],
['tsan==1', {
'target_conditions': [
@@ -3599,6 +3606,7 @@
'xcode_settings': {
'OTHER_CFLAGS': [
'-fsanitize=address',
+ '-mllvm -asan-globals=0', # http://crbug.com/196561
'-w', # http://crbug.com/162783
],
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698