Do not instrument globals when running ASan on Mac.

Do not instrument globals when running ASan on Mac.
There is a subtle bug in the instrumentation of globals for ObjC
(https://code.google.com/p/address-sanitizer/issues/detail?id=171),
which manifests in random errors in tests on 10.8 (e.g. issue 196561)

BUG=196561
TBR=thakis
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193925

[Alexander Potapenko, 2013-04-12 14:06:24]

TBR
I'm landing this in order to hotfix the ASan Mac buildbots after the 10.8
migration. Disabling the globals instrumentation should fix the sandbox
warnings.

[Alexander Potapenko, 2013-04-12 14:26:41]

Committed patchset #4 manually as r193925.

[Nico, 2013-04-12 14:40:07]

Lgtm
On Apr 12, 2013 7:26 AM, <glider@chromium.org> wrote:

> Committed patchset #4 manually as r193925.
>
>
https://codereview.chromium.**org/14109004/<https://codereview.chromium.org/1...
>

[Nico, 2013-04-22 22:20:29]

https://codereview.chromium.org/14109004/diff/7001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/14109004/diff/7001/build/common.gypi#newcode2984
build/common.gypi:2984: '-mllvm -asan-globals=0',  # http://crbug.com/196561
Sorry, I missed this: 'cflags' isn't used on mac. You probably want
'xcodesettings': { 'OTHER_CFLAGS': ...} instead. As is, this is a no-op.

[Alexander Potapenko, 2013-04-23 10:09:04]

https://codereview.chromium.org/14109004/diff/7001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/14109004/diff/7001/build/common.gypi#newcode2984
build/common.gypi:2984: '-mllvm -asan-globals=0',  # http://crbug.com/196561
On 2013/04/22 22:20:29, Nico wrote:
> Sorry, I missed this: 'cflags' isn't used on mac. You probably want
> 'xcodesettings': { 'OTHER_CFLAGS': ...} instead. As is, this is a no-op.

See below, I'm also setting -asan-globals=0 in xcode_settings.

BTW, this is weird. Why can't we just append cflags to OTHER_CFLAGS when
generating Xcode projects?