pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart - Issue 1410893002: Disable completion in comment text.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart

Issue 1410893002: Disable completion in comment text. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart ('k') | pkg/analysis_server/lib/src/services/completion/keyword_contributor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart b/pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart

index dac00564df3d4bae49e2d27fa70bd073f4ff60db..b283ce9adae57f6f5c58390807fe9caf1527e666 100644

--- a/pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart

+++ b/pkg/analysis_server/lib/src/services/completion/imported_reference_contributor.dart

@@ -30,6 +30,11 @@ class ImportedReferenceContributor extends DartCompletionContributor {

@override

bool computeFast(DartCompletionRequest request) {

+ // Don't suggest in comments.

+ if (request.target.isCommentText) {

+ return true;

+ }

OpType optype = request.optype;

if (!optype.isPrefixed) {

if (optype.includeReturnValueSuggestions ||