Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: build/config/ui.gni

Issue 1410883007: headless: Add gn settings for embedded build and headless mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix chrome/test/BUILD.gn Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains UI-related build flags (see features.gni for Chrome 5 # This file contains UI-related build flags (see features.gni for Chrome
6 # feature-related ones). These should theoretically be moved to the ui 6 # feature-related ones). These should theoretically be moved to the ui
7 # directory. 7 # directory.
8 # 8 #
9 # However, today we have many "bad" dependencies on some of these flags from, 9 # However, today we have many "bad" dependencies on some of these flags from,
10 # e.g. base, so they need to be global to match the GYP configuration. Also, 10 # e.g. base, so they need to be global to match the GYP configuration. Also,
11 # anything that needs a grit define must be in either this file or features.gni. 11 # anything that needs a grit define must be in either this file or features.gni.
12 # 12 #
13 # PLEASE TRY TO AVOID ADDING FLAGS TO THIS FILE in cases where grit isn't 13 # PLEASE TRY TO AVOID ADDING FLAGS TO THIS FILE in cases where grit isn't
14 # required. See the declare_args block of BUILDCONFIG.gn for advice on how 14 # required. See the declare_args block of BUILDCONFIG.gn for advice on how
15 # to set up feature flags. 15 # to set up feature flags.
16 16
17 import("//build/config/chromecast_build.gni") 17 import("//build/config/chromecast_build.gni")
18 import("//build/config/headless_build.gni")
18 19
19 declare_args() { 20 declare_args() {
20 # Indicates if Ash is enabled. Ash is the Aura Shell which provides a 21 # Indicates if Ash is enabled. Ash is the Aura Shell which provides a
21 # desktop-like environment for Aura. Requires use_aura = true 22 # desktop-like environment for Aura. Requires use_aura = true
22 use_ash = (is_win || is_linux) && !is_chromecast 23 use_ash = (is_win || is_linux) && !is_chromecast && !is_headless
jam 2015/10/26 17:05:31 curious, why?
Sami 2015/10/26 18:09:06 Is there a reason why we'd want to have a full des
jam 2015/10/30 16:15:49 good point, ok
23 24
24 # Indicates if Ozone is enabled. Ozone is a low-level library layer for Linux 25 # Indicates if Ozone is enabled. Ozone is a low-level library layer for Linux
25 # that does not require X11. Enabling this feature disables use of glib, x11, 26 # that does not require X11. Enabling this feature disables use of glib, x11,
26 # Pango, and Cairo. Default to false on non-Chromecast builds. 27 # Pango, and Cairo. Default to false on non-Chromecast builds.
27 use_ozone = is_chromecast && !is_android 28 use_ozone = (is_chromecast || is_headless) && !is_android
28 29
29 # Indicates if Aura is enabled. Aura is a low-level windowing library, sort 30 # Indicates if Aura is enabled. Aura is a low-level windowing library, sort
30 # of a replacement for GDI or GTK. 31 # of a replacement for GDI or GTK.
31 use_aura = is_win || is_linux || is_chromecast 32 use_aura = is_win || is_linux || is_chromecast || is_headless
jam 2015/10/26 17:05:31 is this really necessary? i.e. you're targeting li
Sami 2015/10/26 18:09:06 Yes, but don't you need to enable Aura to be able
jam 2015/10/30 16:15:49 if so, then this should key off ozone. but ozone i
Sami 2015/11/05 19:08:17 Ah, got it, is_linux should be enough. Removed.
32 33
33 # True means the UI is built using the "views" framework. 34 # True means the UI is built using the "views" framework.
34 toolkit_views = 35 toolkit_views = (is_mac || is_win || is_chromeos || use_aura) &&
35 (is_mac || is_win || is_chromeos || use_aura) && !is_chromecast 36 !is_chromecast && !is_headless
jam 2015/10/26 17:05:31 curious why?
Sami 2015/10/26 18:09:06 Similarly to disabling ash, this gets rid of brows
jam 2015/10/30 16:15:49 if the ui isn't built using views, then which tool
Sami 2015/11/05 19:08:17 We've explored this a little more now and I think
36 37
37 # Whether the entire browser uses toolkit-views on Mac instead of Cocoa. 38 # Whether the entire browser uses toolkit-views on Mac instead of Cocoa.
38 mac_views_browser = false 39 mac_views_browser = false
39 40
40 # Whether we should use GTKv3 instead of GTKv2. 41 # Whether we should use GTKv3 instead of GTKv2.
41 use_gtk3 = false 42 use_gtk3 = false
42 43
43 # Optional system libraries. 44 # Optional system libraries.
44 use_xkbcommon = false 45 use_xkbcommon = false
45 } 46 }
(...skipping 23 matching lines...) Expand all
69 } 70 }
70 71
71 # Whether to use atk, the Accessibility ToolKit library 72 # Whether to use atk, the Accessibility ToolKit library
72 use_atk = is_desktop_linux && use_x11 73 use_atk = is_desktop_linux && use_x11
73 74
74 use_clipboard_aurax11 = is_linux && use_aura && use_x11 75 use_clipboard_aurax11 = is_linux && use_aura && use_x11
75 76
76 enable_hidpi = is_mac || is_win || is_linux 77 enable_hidpi = is_mac || is_win || is_linux
77 78
78 enable_topchrome_md = is_chromeos || is_win || is_linux 79 enable_topchrome_md = is_chromeos || is_win || is_linux
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698