Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1410873012: events: Preserve pointer details in native MouseEvent constructor (Closed)

Created:
5 years, 1 month ago by spang
Modified:
5 years, 1 month ago
Reviewers:
sadrul, robert.bradford
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

events: Preserve pointer details in native MouseEvent constructor This prevents losing the pointer details when converting from "native" events. BUG=516706 TEST=Added some logs, RenderWidgetHostViewAura::OnMouseEvent gets pointer_details().force() for stylus input Committed: https://crrev.com/37829a5c713e53ebc33f31667932bb3e46a799d5 Cr-Commit-Position: refs/heads/master@{#358848}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -2 lines) Patch
M ui/events/cocoa/events_mac.mm View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/event.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/event_utils.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/events/event_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/events_default.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M ui/events/events_stub.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/win/events_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/x/events_x.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
spang
5 years, 1 month ago (2015-11-04 22:56:39 UTC) #2
robert.bradford
lgtm. Thanks Michael!
5 years, 1 month ago (2015-11-05 12:14:15 UTC) #4
sadrul
lgtm https://codereview.chromium.org/1410873012/diff/1/ui/events/x/events_x.cc File ui/events/x/events_x.cc (right): https://codereview.chromium.org/1410873012/diff/1/ui/events/x/events_x.cc#newcode682 ui/events/x/events_x.cc:682: I really quite dislike adding more of these ...
5 years, 1 month ago (2015-11-10 16:24:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410873012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410873012/1
5 years, 1 month ago (2015-11-10 16:25:37 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/121165)
5 years, 1 month ago (2015-11-10 16:45:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410873012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410873012/1
5 years, 1 month ago (2015-11-10 16:48:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410873012/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410873012/20001
5 years, 1 month ago (2015-11-10 16:49:30 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-10 18:04:33 UTC) #17
commit-bot: I haz the power
5 years, 1 month ago (2015-11-10 18:05:12 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/37829a5c713e53ebc33f31667932bb3e46a799d5
Cr-Commit-Position: refs/heads/master@{#358848}

Powered by Google App Engine
This is Rietveld 408576698