Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1410863002: [Interpreter] Add support for Throw. (Closed)

Created:
5 years, 2 months ago by rmcilroy
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer, oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add support for Throw. Adds support for throwing exceptions. Adds the bytecode Throw. BUG=v8:4280 LOG=N Committed: https://crrev.com/4d62978d634f178b9c24be19e1be8a36fc40df0a Cr-Commit-Position: refs/heads/master@{#31366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -9 lines) Patch
M src/bailout-reason.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/interpreter-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/interpreter-assembler.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 3 chunks +11 lines, -4 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 chunk +5 lines, -1 line 0 comments Download
M src/interpreter/bytecodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/interpreter/interpreter.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 1 chunk +50 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410863002/1
5 years, 2 months ago (2015-10-16 16:54:39 UTC) #2
rmcilroy
Benedikt / Orion, PTAL, thanks.
5 years, 2 months ago (2015-10-16 16:54:55 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-16 17:18:39 UTC) #6
Benedikt Meurer
LGTM from my side (haven't checked the tests).
5 years, 2 months ago (2015-10-18 11:28:39 UTC) #7
oth
lgtm, thanks.
5 years, 2 months ago (2015-10-19 08:59:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410863002/1
5 years, 2 months ago (2015-10-19 09:34:58 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-19 10:59:04 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-19 10:59:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d62978d634f178b9c24be19e1be8a36fc40df0a
Cr-Commit-Position: refs/heads/master@{#31366}

Powered by Google App Engine
This is Rietveld 408576698