Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1410853007: [turbofan] Remove use of CallFunctionStub from TurboFan. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove use of CallFunctionStub from TurboFan. Use the Call builtin instead, which does the right thing(TM) always, especially since the CallFunctionStub is going away. R=jarin@chromium.org BUG=v8:4413 LOG=n Committed: https://crrev.com/309c36f5a999af32bd0303fc60e5ee02edf9d21b Cr-Commit-Position: refs/heads/master@{#31794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -101 lines) Patch
M src/code-factory.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 9 chunks +4 lines, -11 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/js-operator.h View 3 chunks +26 lines, -24 lines 0 comments Download
M src/compiler/js-operator.cc View 3 chunks +23 lines, -9 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/unittests/compiler/js-builtin-reducer-unittest.cc View 5 chunks +13 lines, -16 lines 0 comments Download
M test/unittests/compiler/js-context-relaxation-unittest.cc View 10 chunks +20 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-04 14:32:28 UTC) #1
Jarin
lgtm
5 years, 1 month ago (2015-11-04 14:51:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1410853007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1410853007/1
5 years, 1 month ago (2015-11-04 14:52:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 15:04:22 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 15:05:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/309c36f5a999af32bd0303fc60e5ee02edf9d21b
Cr-Commit-Position: refs/heads/master@{#31794}

Powered by Google App Engine
This is Rietveld 408576698