chrome/browser/safe_browsing/remote_database_manager.h - Issue 1410853003: [Safe Browsing] Only check main frame and iframe URLs on Mobile, for speed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/remote_database_manager.h

Issue 1410853003: [Safe Browsing] Only check main frame and iframe URLs on Mobile, for speed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rm unecessary thread restriction that interferes with tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/local_database_manager.cc ('k') | chrome/browser/safe_browsing/remote_database_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/remote_database_manager.h

diff --git a/chrome/browser/safe_browsing/remote_database_manager.h b/chrome/browser/safe_browsing/remote_database_manager.h

index a6b7340d5958a90a733dc6be02c9f12dbf100a61..0443010dd3e2a7b012494c3ffc7842c6e253d402 100644

--- a/chrome/browser/safe_browsing/remote_database_manager.h

+++ b/chrome/browser/safe_browsing/remote_database_manager.h

@@ -30,6 +30,8 @@ class RemoteSafeBrowsingDatabaseManager : public SafeBrowsingDatabaseManager {

bool IsSupported() const override;

+ bool ChecksAreAlwaysAsync() const override;

+ bool CanCheckResourceType(content::ResourceType resource_type) const override;

bool CanCheckUrl(const GURL& url) const override;

bool download_protection_enabled() const override;

bool CheckBrowseUrl(const GURL& url, Client* client) override;

@@ -63,6 +65,9 @@ class RemoteSafeBrowsingDatabaseManager : public SafeBrowsingDatabaseManager {

std::vector<ClientRequest*> current_requests_;

bool enabled_;

+ std::set<content::ResourceType> resource_types_to_check_;

+ bool is_android_field_trial_enabled_;

friend class base::RefCountedThreadSafe<RemoteSafeBrowsingDatabaseManager>;

DISALLOW_COPY_AND_ASSIGN(RemoteSafeBrowsingDatabaseManager);

}; // class RemoteSafeBrowsingDatabaseManager

« no previous file with comments | « chrome/browser/safe_browsing/local_database_manager.cc ('k') | chrome/browser/safe_browsing/remote_database_manager.cc » ('j') | no next file with comments »