Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4227)

Unified Diff: chrome/browser/renderer_host/safe_browsing_resource_throttle.h

Issue 1410853003: [Safe Browsing] Only check main frame and iframe URLs on Mobile, for speed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rm unecessary thread restriction that interferes with tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/renderer_host/safe_browsing_resource_throttle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/safe_browsing_resource_throttle.h
diff --git a/chrome/browser/renderer_host/safe_browsing_resource_throttle.h b/chrome/browser/renderer_host/safe_browsing_resource_throttle.h
index e39d7f3d55b3c6c9d51068d81c1fd7be9a698425..8f2e4ea89788d0aa3e55c0439816a533b39582f5 100644
--- a/chrome/browser/renderer_host/safe_browsing_resource_throttle.h
+++ b/chrome/browser/renderer_host/safe_browsing_resource_throttle.h
@@ -86,17 +86,9 @@ class SafeBrowsingResourceThrottle
const std::string& metadata) override;
protected:
- enum DeferAtStartSetting {
- DEFER_AT_START,
- DONT_DEFER_AT_START
- };
-
- SafeBrowsingResourceThrottle(
- const net::URLRequest* request,
- content::ResourceType resource_type,
- SafeBrowsingService* sb_service,
- DeferAtStartSetting defer_setting,
- SafeBrowsingService::ResourceTypesToCheck types_to_check);
+ SafeBrowsingResourceThrottle(const net::URLRequest* request,
+ content::ResourceType resource_type,
+ SafeBrowsingService* sb_service);
private:
// Describes what phase of the check a throttle is in.
@@ -156,13 +148,6 @@ class SafeBrowsingResourceThrottle
const char* name,
const char* value);
- // True if we want to block the starting of requests until they're
- // deemed safe. Otherwise we let the resource partially load.
- const bool defer_at_start_;
-
- // Check all types, or just the dangerous ones?
- const SafeBrowsingService::ResourceTypesToCheck resource_types_to_check_;
-
State state_;
DeferState defer_state_;
« no previous file with comments | « no previous file | chrome/browser/renderer_host/safe_browsing_resource_throttle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698