chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc - Issue 1410853003: [Safe Browsing] Only check main frame and iframe URLs on Mobile, for speed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

Issue 1410853003: [Safe Browsing] Only check main frame and iframe URLs on Mobile, for speed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests, fix comment per mattm Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/safe_browsing_resource_throttle.cc ('K') | « chrome/browser/safe_browsing/remote_database_manager_unittest.cc ('k') | chrome/browser/safe_browsing/safe_browsing_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

index 96f83526b831222fb98aa7378a842f112d50e741..ac6e67c6b337d732c29ebe877a7aeead9c385c40 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc

@@ -102,6 +102,14 @@ class FakeSafeBrowsingDatabaseManager : public TestSafeBrowsingDatabaseManager {

badurls[url.spec()] = threat_type;

}

+ // These are called when checking URLs, so we implement them.

+ bool IsSupported() const override { return true; }

+ bool ChecksAreAlwaysAsync() const override { return false; }

+ bool CanCheckResourceType(

+ content::ResourceType /* resource_type */) const override {

+ return true;

+ }

// Called during startup, so must not check-fail.

bool CheckExtensionIDs(const std::set<std::string>& extension_ids,

Client* client) override {