Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1834)

Unified Diff: chrome/browser/safe_browsing/local_database_manager.cc

Issue 1410853003: [Safe Browsing] Only check main frame and iframe URLs on Mobile, for speed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests, fix comment per mattm Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/local_database_manager.cc
diff --git a/chrome/browser/safe_browsing/local_database_manager.cc b/chrome/browser/safe_browsing/local_database_manager.cc
index fd461dbc7578200464cefa4ea75794e2014a300c..4d3adca69dbfed0e7f43738744922b19d0fce771 100644
--- a/chrome/browser/safe_browsing/local_database_manager.cc
+++ b/chrome/browser/safe_browsing/local_database_manager.cc
@@ -314,6 +314,16 @@ bool LocalSafeBrowsingDatabaseManager::IsSupported() const {
return true;
}
+bool LocalSafeBrowsingDatabaseManager::ChecksAreAlwaysAsync() const {
+ return false;
+}
+
+bool LocalSafeBrowsingDatabaseManager::CanCheckResourceType(
+ content::ResourceType resource_type) const {
+ // We check all types since most checks are fast.
+ return true;
+}
+
bool LocalSafeBrowsingDatabaseManager::CanCheckUrl(const GURL& url) const {
return url.SchemeIs(url::kFtpScheme) ||
url.SchemeIs(url::kHttpScheme) ||

Powered by Google App Engine
This is Rietveld 408576698